Jira (PUP-11164) launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists

[Clay Caviness (Jira)]

Title: Message Title

Clay Caviness created an issue   Puppet / PUP-11164 launchd service provider fails if a parsable but invalid LaunchAgent or LaunchDaemon plist file exists Issue Type: Bug Affects Versions: PUP 7.8.0 Assignee: Unassigned Components: Types and Providers Created: 2021/07/08 3:49 PM Priority: Normal Reporter: Clay Caviness If a file in the LaunchAgents or LaunchDaemons paths is encountered that's parseable by Puppet::Util::Plist.read_plist_from_file but not a valid launchd plist file, then Puppet will crash with an error. To reproduce: # echo "aaa" >/Library/LaunchDaemons/invalid.txt # puppet resource service Error: Could not run: undefined method `has_key?' for "aaa":String In launchd.rb line 141, the parsed plist (job) is checked with .has_key? to ensure a Label is present. If the parsed plist is not a Hash, though, this will fail. I expect the correct course of action is to add a job.is_a?(Hash) check first. Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.406437.1625784567000.77553.1625784600361%40Atlassian.JIRA.