Jira (PUP-11166) Don't change current working directory when listing modules

Josh Cooper (Jira) Thu, 08 Jul 2021 16:55:07 -0700

Title: Message Title

Josh Cooper created an issue

Issue Type:	Bug
Assignee:	Unassigned
Created:	2021/07/08 4:54 PM
Priority:	Normal
Reporter:	Josh Cooper

When listing modules by path, puppet changes the current working directory unnecessarily. This was first reported in PUP-9997, but broken out here into a separate issue:

def modules_by_path

    modules_by_path = {}

    modulepath.each do |path|

      if Puppet::FileSystem.exist?(path)

        Dir.chdir(path) do

          module_names = Dir.entries(path).select do |name|

            Puppet::Module.is_module_directory?(name, path)

end

          modules_by_path[path] = module_names.sort.map do |name|

            Puppet::Module.new(name, File.join(path, name), self)

end

end

      else

        modules_by_path[path] = []

end

end

    modules_by_path

end

Add Comment

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.406447.1625788461000.77595.1625788500053%40Atlassian.JIRA.

Jira (PUP-11166) Don't change current working directory when listing modules

Reply via email to