Jira (PUP-11196) puppet warns about BOM and US-ASCII encoding

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-11196 puppet warns about BOM and US-ASCII encoding Issue Type: Bug Assignee: Unassigned Created: 2021/08/03 10:57 AM Priority: Normal Reporter: Josh Cooper The fix for PUP-8243 causes ruby to generate a warning if the default external encoding is US-ASCII: /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/file_system/file_impl.rb:83: warning: BOM with non-UTF encoding US-ASCII is nonsense Since ASCII characters are single bytes, there is no need for a BOM to detect byte ordering (LSB/MSB), hence the message. I had assumed ruby would just ignore the `bom` prefix. We'll need to check that the current external encoding starts with `utf-` (case-insensitively I think), and only add the `bom` prefix if it does. See https://github.com/puppetlabs/puppet/pull/8639#issuecomment-891939114 Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.409781.1628013472000.98128.1628013480124%40Atlassian.JIRA.