ruby2.4 runs in 25

Josh Cooper (Jira) Thu, 19 Aug 2021 10:52:07 -0700

Title: Message Title

Josh Cooper commented on

It feels weird that Puppet has a Fact indirector, but doesn't use it everywhere

Yep very true. We made some progress during Facter 3 development to eliminate places where we were calling facter directly, such as https://github.com/puppetlabs/puppet/commit/f41800ab4c0a928ff4f38ad5d1f6bd1e2b5619cd. But there are still places where we need to access facter while bootstrapping puppet, such as resolving the certname -> fqdn.

Also puppetserver wants the ability to load puppet without loading facter, see PUP-9686.

One idea is to allow a caller to register a facter implementation, similar to how callers (like puppetserver) register an http client implementation today:

facter_impl = FacterTestImpl.new

Puppet.initialize_settings([], true, true, http: ..., facter: facter_impl)

where FacterTestImpl implements the Facter API but always returns a canned set of values.

Then modify puppet so that all calls to Facter go through the runtime:

Puppet.runtime[:facter].get(:osversion)

Then something like rspec-puppet-facts could register the test facter implementation based on facts in facterdb?

Add Comment

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.380977.1608048829000.112313.1629395520121%40Atlassian.JIRA.

Jira (FACT-3039) Puppet6/ruby2.5 runs in 42 minutes, where Puppet5/ruby2.4 runs in 25

Reply via email to