Jira (PUP-11184) Autoloader is confused by Windows 8.3 paths

Josh Cooper (Jira) Fri, 17 Sep 2021 14:46:05 -0700

Title: Message Title

Josh Cooper commented on

This issue is a result of the switch to require_relative and can be reproduced in puppet 7.6.0 (before the ruby patch). It seems to be ruby bug with short filename and relative_require:

C:\>md abcdefghijk

C:\>cd abcdef~1

C:\abcdef~1>type *rb

a.rb

puts "dir a #{__dir__}"

require_relative 'b'

puts load('C:\abcdefghijk\b.rb')

b.rb

puts "dir b #{__dir__}"

require_relative 'c'

c.rb

puts "dir c #{__dir__}"

require 'tempfile'

class C < DelegateClass(File); end

C:\ABCDEF~1>ruby a.rb

dir a C:/ABCDEF~1

dir b C:/ABCDEF~1

dir c C:/ABCDEF~1

dir c C:/abcdefghijk

Traceback (most recent call last):

        2: from a.rb:3:in `<main>'

        1: from a.rb:3:in `load'

C:/abcdefghijk/c.rb:3:in `<top (required)>': superclass mismatch for class C (TypeError)

This fails because c.rb is loaded first using its shortname, then an attempt is made it load it again using its long name.

Puppet runs into this, because the autoloader uses Dir.glob to find candidate files to load, and ruby always returns globbed children using long paths:

      dir = Pathname.new(File.expand_path(dir))

      Dir.glob(File.join(dir, path, "*.rb")).collect do |file|

        Pathname.new(file).relative_path_from(dir).to_s

end

Interestingly, Pathname#relative_path_from gets confused with file is a long path and dir is a short path:

 ../../../../../../../Program Files/Puppet Labs/Puppet/puppet/lib/ruby/vendor_ruby/puppet/provider/exec/posix

It's possible to normalize that using File.expand_path:

irb(main):001:0> File.expand_path("../../../../../../../Program Files/Puppet Labs/Puppet/puppet/lib/ruby/vendor_ruby/puppet/provider/exec/posix")

=> "C:/Program Files/Puppet Labs/Puppet/puppet/lib/ruby/vendor_ruby/puppet/provider/exec/posix"

But I think the least surprising thing would be to resolve the long path name for the base dir so that the globbed children have the same prefix. Some of this was done in ~~PUP-6557~~, but the autoloader wasn't touched. It didn't need to be because we weren't using require_relative yet.

Add Comment

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.408088.1626998099000.133279.1631915160114%40Atlassian.JIRA.

Jira (PUP-11184) Autoloader is confused by Windows 8.3 paths

Reply via email to