Jira (PUP-9561) puppet language functions are 11,350x slower than ruby functions

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-9561   Re: puppet language functions are 11,350x slower than ruby functions Actually the type inference is much worse than I expected. Here are 3 manifests, using reduce, merge and merge2 which is the same as merge except the memo isn't passed to the block. ❯ cat reduce.pp $test = generate('/bin/sh', '-c', 'seq 1 4000').split("\n") $result = $test.reduce({}) |$memo,$value| { $memo + { "key $value" => "foo" } }   ❯ cat merge.pp $test = generate('/bin/sh', '-c', 'seq 1 4000').split("\n") $result = merge($test) |$memo,$value| { { "key $value" => "foo" } }   ❯ cat merge2.pp $test = generate('/bin/sh', '-c', 'seq 1 4000').split("\n") $result = merge($test) |$value| { { "key $value" => "foo" } } Using puppet#3828aabe8d32368faa5cdc1a428189d0cb117e52, I get: ❯ time bundle exec puppet apply reduce.pp Notice: Compiled catalog for localhost in environment production in 8.21 seconds Notice: Applied catalog in 0.02 seconds bundle exec puppet apply reduce.pp 10.02s user 0.17s system 99% cpu 10.266 total   ❯ time bundle exec puppet apply merge.pp Notice: Compiled catalog for localhost in environment production in 8.09 seconds Notice: Applied catalog in 0.02 seconds bundle exec puppet apply merge.pp 9.88s user 0.19s system 99% cpu 10.155 total   ❯ time bundle exec puppet apply merge2.pp Notice: Compiled catalog for localhost in environment production in 0.19 seconds Notice: Applied catalog in 0.02 seconds bundle exec puppet apply merge2.pp 2.04s user 0.21s system 96% cpu 2.337 total So merge is only a little bit better than reduce since it doesn't copy the hash each iteration. But it's still terrible. Since the reduce and merge block parameters don't specify a type, they effectively accept PAnyType. Which I think means all of the type inference we're doing is for naught. I pushed a branch https://github.com/puppetlabs/puppet/compare/main...joshcooper:any_callable_9561 that skips type inference if the parameter types are all PAnyType. With that change, times drop to: ❯ time bundle exec puppet apply reduce.pp Notice: Compiled catalog for localhost in environment production in 0.29 seconds Notice: Applied catalog in 0.02 seconds bundle exec puppet apply reduce.pp 2.13s user 0.19s system 96% cpu 2.403 total   ❯ time bundle exec puppet apply merge.pp Notice: Compiled catalog for localhost in environment production in 0.16 seconds Notice: Applied catalog in 0.02 seconds bundle exec puppet apply merge.pp 1.96s user 0.20s system 95% cpu 2.262 total   ❯ time bundle exec puppet apply merge2.pp Notice: Compiled catalog for localhost in environment production in 0.15 seconds Notice: Applied catalog in 0.02 seconds bundle exec puppet apply merge2.pp 1.92s user 0.21s system 95% cpu 2.214 total Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300276.1552587373000.141860.1632871920095%40Atlassian.JIRA.