Jira (PUP-6585) Remove internal usage of Puppet::Util.absolute_path?(path) / replace with Pathname.new(path)

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-6585   Re: Remove internal usage of Puppet::Util.absolute_path?(path) / replace with Pathname.new(path) It turns out our absolute_path? method behaves differently than Pathname#absolute? when handling so called drive relative Windows paths like C:dir: irb(main):002:0> Puppet::Util.absolute_path?('C:dir') => false irb(main):003:0> Pathname.new('C:dir').absolute? => true ... irb(main):006:0> Puppet::Util.absolute_path?('/dir') => false irb(main):007:0> Pathname.new('/dir').absolute? => true I don't really understand the pathname behavior. The MSDN docs say https://docs.microsoft.com/en-us/dotnet/standard/io/file-path-formats#traditional-dos-paths If all three components (volume/drive letter, directory, optional filename) are present, the path is absolute. But then it goes on to say: '\Program Files\Custom Utilities\StringFinder.exe' is an absolute path from the root of the current drive. Given the subtly, I'm going to close this as won't fix. Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.145280.1470350089000.153280.1634058720702%40Atlassian.JIRA.