Issue #7088 has been updated by Nigel Kersten.

Status changed from Needs Decision to Closed

We're not going to change this again. It was introduced in 0.25.x, and has been 
consistent since then.

We just shouldn't make this same mistake again...
----------------------------------------
Bug #7088: fqdn_rand is not backwards compatibile with 0.24.8
https://projects.puppetlabs.com/issues/7088

Author: Jeff McCune
Status: Closed
Priority: Normal
Assignee: Nigel Kersten
Category: 
Target version: 
Affected Puppet version: 
Keywords: 
Branch: 


# Overview #

The fqdn_rand behavior has changed from version 0.24.8 to 2.6 related to #2601

The new function is appending a stray colon onto the end of the fully qualified 
domain name string where as the previous version did not, resulting in a 
different MD5 seed value.

  Old Code: MD5.new(lookupvar('fqdn'))
  New Code: MD5.new([lookupvar('fqdn'),args].join(':'))

In the new code, there will always be a trailing colon since args will be nil 
or an empty array.

# Expected Behavior #

fqdn_rand should return consistent results across versions

# Actual Behavior #

fqdn_rand behavior is inconsistent across Puppet versions.

# Detail #

I'm not so sure anything should change in the code.  There are users likely 
relying on fqdn_rand today and I'd hate to see all of their cron resources 
change suddenly if they upgrade to a new version.

# Work Around #

For clusters of Puppet Masters where both 0.24.8 and 2.6.4 are executing, 
fqdn_rand may be copied to fqdn_random or some other differnt name.  This 
function may then be deployed as a plugin on both 0.24.8 and 2.6 puppet masters.

Suggest closing this ticket and leaving it in the system for documentation.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to