Jira (PUP-11329) Attempt to redefine entity error on agent if plugins are reloaded

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-11329 Attempt to redefine entity error on agent if plugins are reloaded Issue Type: Bug Assignee: Unassigned Created: 2021/10/26 9:03 AM Priority: Normal Reporter: Josh Cooper If an autoloaded type or provider is loaded prior to pluginsync and then modified during pluginsync, puppet will attempt to reload changed files, which can trigger the "Attempt to redefine entity" error. This is different (I think) than the issue described in SERVER-3034, where the entity is reloaded during catalog compilation. To reproduce from source: require 'puppet' Puppet.initialize_settings Puppet::Util::Log.newdestination(:console)   run_mode = Puppet::Util::RunMode[:agent] Puppet::ApplicationSupport.push_application_context(run_mode)   env = Puppet.lookup(:environments).get!(Puppet[:environment]) Puppet.push_context(current_environment: env, loaders: Puppet::Pops::Loaders.new(env, true))   type = Puppet::Type.type(:exec) loader = type.providerloader   FileUtils.touch(File.join(Dir.pwd, "lib/puppet/type/exec.rb")) pp loader.class.reload_changed(env) $ git rev-parse HEAD 4c0b8e038f4eff680c25cd5ab7874755b7f8966e $ bx ruby redefine.rb Error: Could not autoload puppet/type/exec: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/exec'. Originally set at file:///home/josh/work/puppet/lib/puppet/type/exec.rb?line=2. Traceback (most recent call last): 16: from t.rb:15:in `<main>' 15: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:98:in `reload_changed' 14: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:98:in `each' 13: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:100:in `block in reload_changed' 12: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:78:in `load_file' 11: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:78:in `load' 10: from /home/josh/work/puppet/lib/puppet/type/exec.rb:1:in `<top (required)>' 9: from /home/josh/work/puppet/lib/puppet/type/exec.rb:2:in `<module:Puppet>' 8: from /home/josh/work/puppet/lib/puppet/metatype/manager.rb:73:in `newtype' 7: from /home/josh/work/puppet/lib/puppet/concurrent/lock.rb:10:in `synchronize' 6: from /home/josh/work/puppet/lib/puppet/metatype/manager.rb:131:in `block in newtype' 5: from /home/josh/work/puppet/lib/puppet/pops/loaders.rb:154:in `register_runtime3_type' 4: from /home/josh/work/puppet/lib/puppet/pops/loader/base_loader.rb:75:in `set_entry' 3: from /home/josh/work/puppet/lib/puppet/pops/loader/loader.rb:153:in `synchronize' 2: from /home/josh/work/puppet/lib/puppet/concurrent/lock.rb:10:in `synchronize' 1: from /home/josh/work/puppet/lib/puppet/pops/loader/base_loader.rb:79:in `block in set_entry' /home/josh/work/puppet/lib/puppet/pops/loader/base_loader.rb:135:in `fail_redefine': Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/exec'. Originally set at file:///home/josh/work/puppet/lib/puppet/type/exec.rb?line=2. (ArgumentError) 16: from t.rb:15:in `<main>' 15: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:98:in `reload_changed' 14: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:98:in `each' 13: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:100:in `block in reload_changed' 12: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:78:in `load_file' 11: from /home/josh/work/puppet/lib/puppet/util/autoload.rb:78:in `load' 10: from /home/josh/work/puppet/lib/puppet/type/exec.rb:1:in `<top (required)>' 9: from /home/josh/work/puppet/lib/puppet/type/exec.rb:2:in `<module:Puppet>' 8: from /home/josh/work/puppet/lib/puppet/metatype/manager.rb:73:in `newtype' 7: from /home/josh/work/puppet/lib/puppet/concurrent/lock.rb:10:in `synchronize' 6: from /home/josh/work/puppet/lib/puppet/metatype/manager.rb:131:in `block in newtype' 5: from /home/josh/work/puppet/lib/puppet/pops/loaders.rb:154:in `register_runtime3_type' 4: from /home/josh/work/puppet/lib/puppet/pops/loader/base_loader.rb:75:in `set_entry' 3: from /home/josh/work/puppet/lib/puppet/pops/loader/loader.rb:153:in `synchronize' 2: from /home/josh/work/puppet/lib/puppet/concurrent/lock.rb:10:in `synchronize' 1: from /home/josh/work/puppet/lib/puppet/pops/loader/base_loader.rb:79:in `block in set_entry' /home/josh/work/puppet/lib/puppet/pops/loader/base_loader.rb:135:in `fail_redefine': Could not autoload puppet/type/exec: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/exec'. Originally set at file:///home/josh/work/puppet/lib/puppet/type/exec.rb?line=2. (Puppet::Error) Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.421231.1635264226000.163406.1635264240170%40Atlassian.JIRA.