Jira (PUP-11345) Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-11345 Puppet::FileSystem.chmod doesn't validate its arguments like other FS methods Issue Type: Bug Assignee: Unassigned Created: 2021/11/09 4:48 PM Priority: Normal Reporter: Josh Cooper Puppet::FileSystem methods generally assert that they are passed either a String or Pathname and raise ArgumentError if that isn't the case. For example: irb(main):009:0> Puppet::FileSystem.mkpath(nil) ... ArgumentError (FileSystem implementation expected Pathname, got: 'NilClass') However, Puppet::FileSystem.chmod raises an unhelpful TypeError trying to convert nil to a String: irb(main):007:0> Puppet::FileSystem.chmod(0644, nil) ... TypeError (no implicit conversion of nil into String) The chmod method should raise ArgumentError like the other methods Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.422993.1636505339000.3281.1636505400073%40Atlassian.JIRA.