Jira (PUP-11334) tidy removes non-empty directories

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-11334   Re: tidy removes non-empty directories I can confirm this is a bug with a slightly different reproduction: # cat <<END > tidy.pp tidy { '/tmp/tidy': age => '1h', rmdirs => true, recurse => true, type => 'mtime', } END # cat <<END > script.sh #!/bin/sh -x mkdir -p /tmp/tidy touch /tmp/tidy/file1 touch -d "-5 hours" /tmp/tidy/file2 # the following simulates the directory's mtime being updated when file2 is created above touch -d "-5 hours" /tmp/tidy puppet apply --verbose tidy.pp END # chmod u+x script.sh # ./script.sh ... Info: Loading facts Notice: Compiled catalog for XXX in environment production in 0.02 seconds Info: Using environment 'production' Notice: /Stage[main]/Main/Tidy[/tmp/tidy]: Tidying 2 files Info: Applying configuration version '1636573435' Notice: /Stage[main]/Main/File[/tmp/tidy/file2]/ensure: removed Notice: /Stage[main]/Main/File[/tmp/tidy]/ensure: removed Notice: Applied catalog in 0.01 seconds The problem is that when determining if a directory should be tidied or not, we don't check to see if all of its children will be tidied. And since we set force=>true then we rm -rf the directory. Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.422616.1636393139000.4166.1636576140052%40Atlassian.JIRA.