Jira (PUP-11435) Puppet 6.26 and 7.13 may

[Nick Burgan (Jira)]

Title: Message Title

Nick Burgan commented on PUP-11435   Re: Puppet 6.26 and 7.13 may Found more instances of this cropping up. When we want to use our own test facts, the facter.reset seems to change things to have it start reading facts from the node you are running tests on instead. For example, https://github.com/puppetlabs/puppet-enterprise-modules/blob/main/modules/pe_install/spec/hosts/monolithic_spec.rb is loading up a set of facts from rspec-puppet-facts for different OS types and doing let(:facts} to set them (https://github.com/puppetlabs/puppet-enterprise-modules/blob/main/modules/pe_install/spec/shared/contexts.rb#L11-L18). At https://github.com/puppetlabs/puppet-enterprise-modules/blob/main/modules/pe_install/spec/hosts/monolithic_spec.rb#L267 which runs https://github.com/puppetlabs/puppet-enterprise-modules/blob/main/modules/pe_install/spec/hosts/monolithic_spec.rb#L4-L6, the first compile uses the test's facts, but the second one ends up picking up the test runner node's facts, I assume because the facter.reset happened in there somewhere. Add Comment   This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.432469.1643158630000.2093.1643235300381%40Atlassian.JIRA.