Jira (FACT-3112) Stack trace on invalid facts.d entry

[Steve Traylen (Jira)]

Title: Message Title

Steve Traylen created an issue   Facter / FACT-3112 Stack trace on invalid facts.d entry Issue Type: Improvement Affects Versions: FACT 4.2.5 Assignee: Unassigned Components: Facter 4 Created: 2022/03/31 12:50 AM Environment: CentOS 7  puppet-agent-7.12.0.7.g9fc268bde-4.config8s.x86_64 Priority: Normal Reporter: Steve Traylen We had a bad fact.s fact: /etc/facter/facts.d/queue.py { "": } That is invalid json: # /etc/facter/facts.d/yarn_queue.py | jq . parse error: Unmatched '}' at line 1, column 7 This results in a non-obvious stack trace. Would be good if this caught as a warning or something. Traceback (most recent call last): 23: from /opt/puppetlabs/puppet/bin/facter:10:in `<main>' 22: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/cli/cli_launcher.rb:23:in `start' 21: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.1.0/lib/thor/base.rb:485:in `start' 20: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.1.0/lib/thor.rb:392:in `dispatch' 19: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.1.0/lib/thor/invocation.rb:127:in `invoke_command' 18: from /opt/puppetlabs/puppet/lib/ruby/gems/2.7.0/gems/thor-1.1.0/lib/thor/command.rb:27:in `run' 17: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/cli/cli.rb:124:in `query' 16: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter.rb:454:in `to_user_output' 15: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter.rb:521:in `resolve_facts_for_user_query' 14: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact_manager.rb:24:in `resolve_facts' 13: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:7:in `resolve_facts' 12: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:19:in `external_facts' 11: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:19:in `each' 10: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/fact/external/external_fact_manager.rb:21:in `block in external_facts' 9: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:127:in `value' 8: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:177:in `searching' 7: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:137:in `block in value' 6: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/fact.rb:159:in `resolve_value' 5: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter.rb:135:in `core_value' 4: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/models/fact_collection.rb:21:in `build_fact_collection!' 3: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/models/fact_collection.rb:21:in `each' 2: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/models/fact_collection.rb:24:in `block in build_fact_collection!' 1: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/models/fact_collection.rb:80:in `bury_fact' /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/models/fact_collection.rb:57:in `bury': 2 or more arguments required (ArgumentError) Add Comment   This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.4189.1648713060057%40Atlassian.JIRA.