Jira (PUP-8405) Knock-out-prefix fails with more than 3 hierarchy levels

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-8405   Re: Knock-out-prefix fails with more than 3 hierarchy levels I updated the title and description to capture some small, but important details. This problem can be triggered if the lookup key appears in 3 (or more) places in the hierarchy(s). So if I have 3 levels for a.yaml, b.yaml and common.yaml, and the classes key appears in all of them: a.yaml --- classes: - --profiles::network - network b.yaml --- classes: - profiles::application common.yaml --- lookup_options: classes: merge: strategy: deep knockout_prefix: -- classes: - profiles::motd - profiles::network Then there will be 2 merges. First a.yaml and b.yaml are merged: classes merging ["--profiles::network", "network"] and ["profiles::application"] Then that result is merged with common.yaml: classes merging ["profiles::application", "network"] and ["profiles::motd", "profiles::network"] The problem is as Thomas and Henrik described earlier. The anti-value "--profiles::network" is only applied during the first merge and is "lost" by the time the second merge takes place, so the value "profiles::network" is not removed/knocked out. This problem can also occur across environment and module layers. However, it is only triggered if there are multiple merges (once in the environment layer and again across layers). Also the issue won't occur if the key only occurs in two places in the hierarchy, since there's only one merge and the value and anti-value cancel each other. Add Comment   This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.233866.1517331565000.36635.1653439020065%40Atlassian.JIRA.