Jira (PUP-11630) puppetlabs-mount_core does not honor remounts on freebsd

[Matt (Jira)]

Title: Message Title

Matt created an issue   Puppet / PUP-11630 puppetlabs-mount_core does not honor remounts on freebsd Issue Type: Bug Assignee: Unassigned Created: 2022/09/23 6:41 AM Priority: Normal Reporter: Matt Puppet Version: 7.15.0 Puppet Server Version: 7.17.0 OS Name/Version: FreeBSD puppetlabs-mount_core (v1.1.0) Hello, I'm using FreeBSD and I have the following mount entry,     mount { '/dev/fd':     ensure => mounted,     name => '/dev/fd',     device => 'fdescfs',     fstype => 'fdescfs',     options => 'rw',     remounts => false   }   which fails with the following output,   Computing checksum on file /etc/fstab Scheduling refresh of Mount[/dev/fd] Mount[/dev/fd](provider=parsed): Remounting Failed to call refresh: Execution of '/sbin/mount -o rw,update /dev/fd' returned 1: mount: fdescfs: Operation not supported Execution of '/sbin/mount -o rw,update /dev/fd' returned 1: mount: fdescfs: Operation not supported   It looks like remounts => false is not honored on freebsd. The relevant code is in mount.rb,    elsif %r{^(FreeBSD|DragonFly|OpenBSD)$}.match?(os) which is missing the check for supports_remounts thus incorrectly assuming all of FreeBSD supports "update". Desired Behavior: the mount should succeed Actual Behavior: mount fails due to the incorrect update parameter Add Comment   This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.469386.1663940507000.36109.1663940520073%40Atlassian.JIRA.