Jira (FACT-3162) Facter 4 reports os.name as "SLES_SAP" on Suse Linux for SAP instead of just "SUSE"

[Aaron Hilton (Jira)]

Title: Message Title

Aaron Hilton created an issue   Facter / FACT-3162 Facter 4 reports os.name as "SLES_SAP" on Suse Linux for SAP instead of just "SUSE" Issue Type: Bug Affects Versions: FACT 4.2.8 Assignee: Unassigned Components: Facter 4 Created: 2022/10/21 1:14 PM Priority: Normal Reporter: Aaron Hilton I am not sure that this is a "functioning as designed" issue as much as it is a "is this best for our customers" issue, however on SLES for SAP systems, Facter 4 returns "SLES_SAP" for the OS Name rather than "SLES". This is functioning as designed, as the /etc/os-release file does have "SLES_SAP" as the name string in /etc/os-release as seen in the following snip...  NAME="SLES_SAP"     VERSION="12-SP1"     VERSION_ID="12.1.0.1"     PRETTY_NAME="SUSE Linux Enterprise Server for SAP Applications 12 SP1"     ID="sles_sap"     ANSI_COLOR="0;32"     CPE_NAME="cpe:/o:suse:sles_sap:12:sp1" The concern is that since this is returning something other then "SLES", this variant of SLES will not work with much of the code released in the Forge or custom code without refactoring the modules to take this version of SLES into account. Also the customer is reporting that on several of their SLES 12.2 for SAP systems the os.release.major fact is resolving to “12.2” and not “12" while “os.distro.release.major” correctly resolves to “12". This fact comes back correct on a SLES 12SP5 box. There appears to be a difference in the format of the VERSION_ID between SAP and non-SAP versions of SLES. Maybe we need to adjust how we are splitting the VERSION_ID. Perhaps the better discussion is if SLES for SAP is a supported OS...   Add Comment   This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472894.1666383285000.50892.1666383300170%40Atlassian.JIRA.