Jira (PUP-11775) Use valid encoding for metadata file reading

[Tony Vu (Jira)]

Title: Message Title

Tony Vu commented on PUP-11775   Re: Use valid encoding for metadata file reading Hmm, that's really weird, I of course can reproduce the behavior Josh Cooper  has described above, but this is what I see in the repl when I pause the test—it looks like there is some weird behavior with relative vs absolute strings????: [36] pry(#<Puppet::Module>)> md_file => "/Users/toneloc/repos/puppet/spec/fixtures/unit/pops/loaders/loaders/dependent_modules_with_metadata/modules/user/metadata.json" [37] pry(#<Puppet::Module>)> File.read("/Users/toneloc/repos/puppet/spec/fixtures/unit/pops/loaders/loaders/dependent_modules_with_metadata/modules/user/metadata.json", encoding: 'utf-8') => "" [38] pry(#<Puppet::Module>)> File.read("spec/fixtures/unit/pops/loaders/loaders/dependent_modules_with_metadata/modules/user/metadata.json", encoding: 'utf-8') => "{\n  \"name\": \"test-user\",\n  \"author\": \"test\",\n  \"description\": \"\",\n  \"license\": \"\",\n  \"source\": \"\",\n  \"version\": \"1.0.0\",\n  \"dependencies\": [\n  ]\n}\n" [39] pry(#<Puppet::Module>)> File.read(md_file, encoding:  'UTF-8') => "{\n  \"name\": \"test-user\",\n  \"author\": \"test\",\n  \"description\": \"\",\n  \"license\": \"\",\n  \"source\": \"\",\n  \"version\": \"1.0.0\",\n  \"dependencies\": [\n  ]\n}\n" [40] pry(#<Puppet::Module>)> File.read(md_file, encoding:  'utf-8') => "" [41] pry(#<Puppet::Module>)> whereamiFrom: /Users/toneloc/repos/puppet/lib/puppet/module.rb:218 Puppet::Module#read_metadata:    215: def read_metadata     216:   md_file = metadata_file     217:   require 'pry-byebug';binding.pry  => 218:   md_file.nil? ? {} : Puppet::Util::Json.load(File.read(md_file, :encoding => 'utf-8'))     219: rescue Errno::ENOENT     220:   {}     221: rescue Puppet::Util::Json::ParseError => e     222:   #TRANSLATORS 'metadata.json' is a specific file name and should not be translated.     223:   msg = _("%{name} has an invalid and unparsable metadata.json file. The parse error: %{error}") % { name: name, error: e.message }     224:   case Puppet[:strict]     225:   when :off     226:     Puppet.debug(msg)     227:   when :warning     228:     Puppet.warning(msg)     229:   when :error     230:     raise FaultyMetadata, msg     231:   end     232:   {}     233: end Add Comment   This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.482208.1677888408000.3237.1678129140026%40Atlassian.JIRA.