Issue #7246 has been updated by R.I. Pienaar. Category set to Plugins Status changed from Unreviewed to Accepted Assignee set to R.I. Pienaar Target version set to 1.2.0
What were you hoping to achieve with the persistent option? We don't use queues and persistence dont really come into play for topics. I'll look at adding the priority for now as a simple configurable setting and park the ticket, we're doing a fair bit of internal tweaking to how messaging works and I'll keep it in mind then so that it can be changed via the API too. Hopefully just having the priority configurable in the cfg files will help you a bit now. ---------------------------------------- Feature #7246: add the ability to add the priority to JMS messages https://projects.puppetlabs.com/issues/7246 Author: Adam Edwards Status: Accepted Priority: Normal Assignee: R.I. Pienaar Category: Plugins Target version: 1.2.0 Keywords: Branch: Affected mCollective version: Currently when mcollective sends the JMS messages via stomp, it doesn't appear to use a JMSpriority, therefore the default is getting used(4). This is currently causing me issues as I have lots of messaging traffic and I need the mcollective to be prioritized over my other messaging traffic. Looking at the rubygems-stomp code, I ran a test and you can pass the priority to the 'send' method as follows: Would someone mind updating the code on line 147 of stomp.rb to be something similar to the following? New Code: <pre> persistent = get_option("stomp.msg.persistent",false) priority = get_option("stomp.msg.priority", 4) @connection.publish(target, msg, {'persistent'=> persistent, 'priority'=> priority}) </pre> Old Code: <pre> @connection.publish(target, msg) </pre> Ideally, if the configuration can support it, it would be nice to have something like... <pre> stomp.msg.headers = {'persistent'=> false, 'priority'=> 9} </pre> this way we could add any additional headers without any need for code changes. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
