Issue #4869 has been updated by Michael Kincaid.
As far as "remove duplication", I think we should just add the productname fact resolution without removing the sp_machine_model fact, in case there is any reliance on the sp fact name that might break. Is this the only fact that needs an OS X-specific resolution? uptime and friends are already implemented, processorcount and physicalprocessorcount are addressed in other tickets (#5135 and #6515 respectively), and we could probably debate what to do with manuf -- I've half a mind to case it as "Apple Computer, Inc." when kernel = Darwin, but I guess there might be some situation in which that's not the "right" answer (hackintoshes...?). ---------------------------------------- Bug #4869: Remove duplication between Mac sp_* facts and non-Mac fact names https://projects.puppetlabs.com/issues/4869 Author: Nathan Rich Status: Accepted Priority: Normal Assignee: Michael Kincaid Category: Target version: Keywords: Branch: Affected Facter version: 'productname' in Facter on OS X should return that which is shown from `sysctl hw.model` currently it's not present, which means manifests will need to have case selects on if it's there or to get sp_ facts -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
