Issue #7468 has been updated by Matt Robinson. Status changed from Ready For Testing to Closed
Merged to 2.7.x in commit:7a3a37366ddeab220b021636153527ff58034aae ---------------------------------------- Bug #7468: Spec test tries to connect to pypi.python.org https://projects.puppetlabs.com/issues/7468 Author: Matt Robinson Status: Closed Priority: Normal Assignee: Matt Robinson Category: Target version: 2.7.x Affected Puppet version: 2.7.0rc2 Keywords: Branch: https://github.com/mmrobins/puppet/tree/ticket/2.7.x/7468-stub_xmlrpc_internet_call The tests are actually executing the network call here: lib/puppet/provider/package/pip.rb51: client = XMLRPC::Client.new2("http://pypi.python.org/pypi";) This results in a couple test failures if you don't have a network connection. ─ [1]% rspec spec/unit/provider/package/pip_spec.rb. ......FF.......... Failures: 1) Puppet::Type::Package::ProviderPip latest should find a version number for Django Failure/Error: @provider.latest.should_not == nil SocketError: getaddrinfo: nodename nor servname provided, or not known # ./lib/puppet/provider/package/pip.rb:53:in `latest' # ./spec/unit/provider/package/pip_spec.rb:77 2) Puppet::Type::Package::ProviderPip latest should not find a version number for sdsfdssdhdfyjymdgfcjdfjxdrssf Failure/Error: @provider.latest.should == nil SocketError: getaddrinfo: nodename nor servname provided, or not known # ./lib/puppet/provider/package/pip.rb:53:in `latest' # ./spec/unit/provider/package/pip_spec.rb:82 The spec and unit tests should never need to call out to the internet, we should stub that portion. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
