Issue #3420 has been updated by Chris Phillips.
I don't understand the logic of this patch. Whilst the name is only "useful"
when the service is a template, why would this not want to be fixed for all
services? The merged patch serves to explicitly preserve the bug in all normal
services..?
def self.to_file(records)
- header + records.collect { |record| record.to_s
}.join("\n").gsub("_naginator_name", NAME_STRING)
+ header + records.collect { |record|
+ record.to_s.sub("_naginator_name", "name").sub(record.type.to_s +
"_name", "name")
+ }.join("\n")
end
(not sure of the need for the code that's left when the if block is removed,
not great at ruby, but it works...)
Or am I missing something? nagios certainly has no problem with the file this
way.
----------------------------------------
Bug #3420: Nagios "name" attribute not output correctly
https://projects.puppetlabs.com/issues/3420
Author: Robin Skoglund
Status: Merged - Pending Release
Priority: Normal
Assignee: Nigel Kersten
Category: nagios
Target version: 2.6.x
Affected Puppet version: 2.6.6
Keywords:
Branch: https://github.com/jamtur01/puppet/tree/tickets/2.6.x/3420
I think I've stumbled upon a bug in the way Naginator outputs the Nagios "name"
attribute.
I have the following `nagios_service` type defined in a manifest:
<pre>
nagios_service { "jmx-${name}":
use => "basic-service",
service_description => "JMX $name",
check_command => "check_jmx_heap_via_ssh!$name",
register => "0",
target => "/usr/local/nagios/etc/generated_services/$name.cfg"
}
</pre>
Expected output:
<pre>
define service {
check_command check_jmx_heap_via_ssh!kidkalkulator
register 0
name jmx-kidkalkulator
service_description JMX kidkalkulator
use basic-service
}
</pre>
Actual output:
<pre>
define service {
check_command check_jmx_heap_via_ssh!kidkalkulator
register 0
## --PUPPET_NAME-- (called '_naginator_name' in the manifest)
jmx-kidkalkulator-test
service_description JMX kidkalkulator
use basic-service
}
</pre>
I attached a patch that changes `puppet/provider/naginator.rb` to output as
expected, but I am not sure whether the patch will break other parts of
Naginator/puppet.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
