Issue #7630 has been updated by Matt Robinson.
This has been blocking #6992 for too long, mostly because I couldn't decide the best way to accomplish this cleanly. After talking with Randall and some other devs the yesterday, we decided to try out not adding denormalized columns to the report format that comes from puppet, but instead to add them in dashboard so that we don't add non-essential data to the puppet report. Also, instead of adding the count columns to the reports table, they should be in the metrics table since some of the counts for resources (failed) already exist. I think what we will want to do with the report format is modify the status column on reports to include the new pending status. That's already a denormalized column, but if we're not going to remove it, we should have it reflect the statuses that we consider reports to be in now that we take noop into account for status. ---------------------------------------- Bug #7630: Add pending_count to resource_statuses in the report format https://projects.puppetlabs.com/issues/7630 Author: Nick Lewis Status: Accepted Priority: Normal Assignee: Category: Target version: Keywords: Branch: https://github.com/nicklewis/puppet-dashboard/tree/ticket/next/7630 Affected URL: Affected Dashboard version: pending_count is analogous to failed_count and out_of_sync_count, and lets us query for resource_statuses which are pending without having to look at resource_events. A resource_status is pending, in this case, if it is not failed and has a pending_count > 0. This will need to be changed in: - the Dashboard db with a migration - the report transformer, with a handler for the new report format - the report generator - existing queries in Dashboard - Puppet will need to add this field A corresponding change may need to be made to report and/or node, perhaps by including "pending" as a possible value for the denormalized "status" field. This will be a part of report format 3. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
