Issue #7196 has been updated by Daniel Pittman.
> The problem is that a node name can be essentially anything, because it > defaults to the node’s certname, which can be just shy of any string. Thus, > they can contain a wide range of characters that have special meaning in > URLs, causing classification to fail or return results for a different node. That includes spaces, right? (Ah, yes, in at least some context whitespace in DN is significant, good.) > Because we don’t know what an arbitrary exec terminus is going to do, we > can’t just URL encode the name in there, so it needs to be done for our case > alone in the external_node tool. Although it would seem reasonable to > mention this as a potential point of concern in whatever documentation we > have on writing external node classifiers. I assume we get the argument passing part of this right already, so that whitespace doesn't split to multiple arguments, but we should probably do something to ensure that users get consistent information. Either way, this explains the context, thanks. ---------------------------------------- Bug #7196: external node tool should URL encode node names https://projects.puppetlabs.com/issues/7196 Author: Nick Lewis Status: Re-opened Priority: Normal Assignee: Category: Target version: Keywords: Branch: Affected URL: Affected Dashboard version: Node names such as "foo/bar", "foo bar", and "foo?bar" currently have problems. "foo/bar" results in a routing error. "foo bar" raises a bad URI exception in the external node tool. "foo?bar" classifies "foo". -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
