Issue #7788 has been updated by Daniel Pittman. Target version changed from 2.7.0 to 2.7.x
Damn. So, I was going through the last little steps in testing this after I merged it locally, before pushing, and we ran into a set of concerns that we don't have time to address right now. Specifically, there are two concrete issues we are worried about here: One, we are concerned that there might be cases where this adds the gem path, but not everything on the Ruby $LOAD_PATH, to the locations our autoloader (or one of the other open-coded implementations of the same) hunt for things on disk. That should be easy enough to verify, but we want (someone) to audit that before this gets merged. Two, we are concerned that this potentially adds trouble when someone has two copies of Puppet installed, one through RubyGems, and the other through an OS package, or from source, or something like that. This introduces a new path that code can get loaded, and it isn't at all clear which will win from the outside. We have a cluster of other issues in the area, though: we need to be able to pluginsync faces and actions, as well as utility functions; we want to make sure we have consistent search paths to avoid the "face discovered, but can't be loaded" showing up in another guise, and that sort of thing. So, from discussion with Nigel and James we are going to hold this off for a bit: the code you have is correct, and ready to merge, and is going to stay there until we merge it as part of sorting out the rest of the mess around this area. So, sorry: I wish I had thought of this earlier, or could more easily convince myself (and Nigel) that this was a safe step toward the ultimate goal right now, rather than having to delay landing it. :/ I really want to see this feature in. ---------------------------------------- Feature #7788: Puppet should allow rubygems to deliver new functionality https://projects.puppetlabs.com/issues/7788 Author: R.I. Pienaar Status: In Topic Branch Pending Merge Priority: Normal Assignee: Nigel Kersten Category: plug-ins Target version: 2.7.x Affected Puppet version: Keywords: Branch: ripienaar/feature/master/7788 It would be desirable to use Rubygems to install things like parser functions. There might be cases where you only want a function on the master, pluginsync would copy it everywhere and everywhere might not have the dependencies needed to run it. If the autoloader considered the rubygem search path while autoloading this should allow gems to extend puppet. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
