Issue #7142 has been updated by Adrien Thebo.

Status changed from Code Insufficient to Tests Insufficient


----------------------------------------
Refactor #7142: facter/lib/util/manufacturer.rb sets facts
https://projects.puppetlabs.com/issues/7142

Author: Adrien Thebo
Status: Tests Insufficient
Priority: Normal
Assignee: Adrien Thebo
Category: 
Target version: 1.6.0
Keywords: 
Branch: https://github.com/adrienthebo/facter/tree/ticket%2Fmaster%2F7142
Affected Facter version: 


It seems unusual that a utility class is adding actual facts, while 
facter/lib/manufacturer.rb simply calls out to the utility class. It seems that 
the roles of these two classes should be swapped to conform to the rest of 
facter more closely.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to