Issue #7682 has been updated by Todd Zullinger.
Ben Hughes wrote: > This has come up before and it's not something we're going to introduce to a > 1.5.x series patch due to completely smashing POLA I'm afraid. > Changing how many people have their manifests written currently on a point > release would not be welcomed. It's not considered a simple bug that facter operatinsystemrelease is returning the kernel version rather than what anyone sane would expect it to return? That's the greater POLA violation I would think. :) It may be worth noting that we changed the operatingsystemrelease fact during the 1.5.x series to make RHEL and CentOS return the same values. See bug #2060, where RHEL was changed to present the full OS release, including the minor version. This change went into 1.5.7. Perhaps there was some backlash from that which makes fixing this obvious bug on Scientific Linux distasteful? I'd be shocked if there were folks using SL that wanted the fact to differ from the same fact on RHEL or CentOS. Unrelated, wouldn't it be better to use the --author option to git commit to better reflect the patch authorship? (And make it easier to track past authors, should anyone wish to do so when asking questions about the code or when doing other history tasks in git?) Anyway, the discussion of which branch to get this on it probably moot now that 1.6.0 is out. I was just reminded of this ticket and figured some discussion might provide a friendly poke to Orion about the CLA, so we can get it committed to the main repos for the next 1.6.x release. :) ---------------------------------------- Bug #7682: Scientific Linux operatingsystemrelease is incorrect, other facts missing https://projects.puppetlabs.com/issues/7682 Author: Orion Poplawski Status: Requires CLA to be signed Priority: Normal Assignee: Category: library Target version: Keywords: Branch: https://github.com/adrienthebo/facter/tree/ticket%2Fmaster%2F7682 Affected Facter version: 1.5.9 # diff facter-1.5.8 facter-1.5.9 5d4 < hardwareisa => x86_64 17d16 < macaddress => 00:16:3E:64:2E:18 25,26c25,27 < operatingsystem => RedHat < operatingsystemrelease => 6.0 --- > operatingsystem => Scientific > operatingsystemrelease => 2.6.32-71.29.1.el6.x86_64 47d50 < uniqueid => 0a0a0929 # ls -l /etc/*release -rw-r--r--. 1 root root 38 Feb 24 13:12 /etc/redhat-release lrwxrwxrwx. 1 root root 14 May 2 19:16 /etc/system-release -> redhat-release # cat /etc/redhat-release Scientific Linux release 6.0 (Carbon) $operatingsystemrelease should be 6.0 Where RedHat is used in other places, Scientific should also be in the list. The attached patch does that. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
