Issue #8116 has been updated by Daniel Pittman. Status changed from Accepted to Merged - Pending Release
https://github.com/puppetlabs/dashboard-module-baseline/commit/4bc452f0369235775b702c44187619e7d999f2eb This turns out to be much easier to solve: we don't actually *care* that we have separate CSS and JS files for the plugin, compared to the baseline, just that we have them load at all. A trivial change to the name we cache the combined files under for the plugin makes everything work as expected. ---------------------------------------- Bug #8116: Plugin resources should be rolled up into all.css and all.js https://projects.puppetlabs.com/issues/8116 Author: Randall Hansen Status: Merged - Pending Release Priority: Normal Assignee: Category: Target version: 1.2 Keywords: Branch: Affected URL: Affected Dashboard version: Running Dashboard in the production environment, I don't think that a plugin's CSS and JS resources are rolled up into all.css and all.js. These resources are created from the arguments passed to `stylesheet_link_tag` and `javascript_include_tag` in `views/layouts/application.html.haml` This means that we will likely need to either: 1. Change how plugin resources are used by Dashboard, to include them in these tags, or 1. Change how all.css and all.js are created. I'm guessing that (1) is easiest and best. It may be that we can use the better `stylesheet_link_tag :all, :cache => true` and defined all the stylesheets elsewhere, outside of the layout. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
