Issue #7688 has been updated by Peter Meier.
Request URL:https://projects.puppetlabs.com/issues/7688 Request Method:POST Status Code:500 Internal Server Error Request Headersview source Accept:text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 Accept-Charset:ISO-8859-1,utf-8;q=0.7,*;q=0.3 Accept-Encoding:gzip,deflate,sdch Accept-Language:en-US,en;q=0.8 Cache-Control:no-cache Connection:keep-alive Content-Length:5422 Content-Type:multipart/form-data; boundary=----WebKitFormBoundary0JAfShzNF5zrOnAC Cookie:km_ai=vjrEkq%2F79eYULzKfIL8aef9YOmM%3D; km_lv=x; km_uq=; __utmz=74632333.1309245068.10.6.utmcsr=puppetlabs.com|utmccn=(referral)|utmcmd=referral|utmcct=/blog/learning-puppet-and-cheat-sheets/; NREUM=s=1309249552818&r=https%3A%2F%2Fprojects.puppetlabs.com%2Fissues%2F7688&p=https%3A%2F%2Fprojects.puppetlabs.com%2Flogin; __utma=74632333.401964810.1308572234.1309245068.1309248395.11; __utmc=74632333; __utmb=74632333.3.10.1309248395; _redmine_session=BAh7CDoMdXNlcl9pZGkBqzoPc2Vzc2lvbl9pZCIlMmIxYzkyNDFjMGFjNGEwNTc3YjdlZjdkYzAxNzUzMTM6EF9jc3JmX3Rva2VuIjFLQVNybkZ4UFdCMGpVM3lwT3krd3JuWXJoVUZFSXJVeXY4bi9ocEZaTDVzPQ%3D%3D--de1000dbcc3159954ea92485e8d3e4dceefac526 Host:projects.puppetlabs.com Origin:https://projects.puppetlabs.com Pragma:no-cache Referer:https://projects.puppetlabs.com/issues/7688 User-Agent:Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.1 (KHTML, like Gecko) Ubuntu/11.04 Chromium/13.0.782.32 Chrome/13.0.782.32 Safari/535.1 Request Payload ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="_method" put ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="authenticity_token" kYS0ywoXmys9rJgz+LJk8NmMzO/xp5HWwt61G5yPeSE= ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[tracker_id]" 2 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[subject]" Review and potentially merge Onyx Point Concat module ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[parent_issue_id]" ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[description]" Puppet Concat Module - This is a module that provides a native type for performing multi-part file concatenation, generally referred to by the Puppet Labs team as the File Fragment Pattern. https://github.com/onyxpoint/pupmod-concat ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[status_id]" 11 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[priority_id]" 4 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[assigned_to_id]" 380 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[category_id]" 135 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[fixed_version_id]" 65 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[start_date]" 2011-05-26 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[due_date]" ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[estimated_hours]" ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[done_ratio]" 0 ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[custom_field_values][11]" ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[custom_field_values][12]" ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="issue[custom_field_values][13]" https://github.com/onyxpoint/pupmod-concat ------WebKitFormBoundary0JAfShzNF5zrOnAC Content-Disposition: form-data; name="notes" > > Problems I encountered: > > > > * Newline problems in the fragments -> fixed in my github repo > > * Diff problem if target file does not yet exist -> fixed in my github repo > > * vardir is not /var/lib/puppet -> fixed in my github repo > > I'll work on getting these pulled and tested as soon as I can. I pushed all my working fixes to the master branch, where the two last commits contain some refactoring I did to prepare the code towards my work on using puppet resources. > > I started working on using real resources within the provider to create the > > necessary files and directories. For example I delegated the fragment > > creation to a simple file resource. However, I encountered some problems > > with ordering the auto generated resources within the graph correctly and > > due to my lack of real provider development knowledge I couldn't fix that > > within time and hence went back to use Volcane's concat module. > > Make sure you check the run times/compile times against complex concat files. > It'll work great in small cases but appears to be exponential in terms of > runtime and resource usage if you don't use the Ruby utilities. Is this filed somewhere as a bug? Because using the ruby utilities interferes very likely with resources that could be managed within the catalog. Using puppet resources would avoid that, as we couldn't manage a resource twice (probably in a different way) with resources, but we can with Ruby utilities. Therefore I think it would be important to avoid that problem. If we can figure out what the exponential shift is causing we might be able to get that fixed in the proper place, rather than using a work around that introduces other problems. > > If people would be interested in my (broken) work I can upload it to a > > separate branch on my github account. > > I'd like to see it. If nothing else, it may provide ideas about how we can > improve our design. I pushed my working changes (still using ruby utilities) to the master branch and pushed a commit with my current attempt to get it working with puppet resources to the branch wip. The main problem I had, was that the auto-generated resources of concat_build (like the parent directories) didn't make it into the catalog for reasons unknown to me. Maybe someone more familiar with provider internals might have a look? Also please note, that this code is not cleaned up properly and is just a snapshot of all my previous attempts to get it working. ---------------------------------------- Feature #7688: Review and potentially merge Onyx Point Concat module https://projects.puppetlabs.com/issues/7688 Author: James Turnbull Status: Needs Decision Priority: Normal Assignee: Nigel Kersten Category: plug-ins Target version: Telly Affected Puppet version: Keywords: Branch: https://github.com/onyxpoint/pupmod-concat Puppet Concat Module - This is a module that provides a native type for performing multi-part file concatenation, generally referred to by the Puppet Labs team as the File Fragment Pattern. https://github.com/onyxpoint/pupmod-concat -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
