Issue #1346 has been updated by Julien GEORGES. File facter-ip_addr-linux.patch added
Hi everyone, I've work on a personal patch for facter 1.5.7-1 to use 'ip addr' instead of 'ifconfig'. I had some trouble with ifconfig when you enable infiniband interfaces. In this situation, ifconfig is obsolete and facter prints a lot of garbage messages like that : <blockquote> Ifconfig uses the ioctl access method to get the full address information, which limits hardware addresses to 8 bytes. Because Infiniband address has 20 bytes, only the first 8 bytes are displayed correctly. </blockquote> Here is my little contribution, you will find my svn diff file attached to this issue (**facter-ip_addr-linux.patch**). **This patch is only for linux usage!** I didn't modify the code for the other systems (like 'OpenBSD', 'NetBSD', 'FreeBSD', 'Darwin'...) because I don't have any of these systems to test my modifications. If you use one of these systems, be careful if you apply this patch. I'll be glad if you give me some return about my work or if you have any advice to improve this patch. Thanks, Julien. ---------------------------------------- Bug #1346: Using 'ip addr' over ifconfig https://projects.puppetlabs.com/issues/1346 Author: Ian Christian Status: Accepted Priority: Normal Assignee: martin krafft Category: library Target version: 2.0.0 Patch: None Keywords: Branch: Affected Facter version: <pre> # facter /usr/lib/ruby/site_ruby/1.8/facter/ipmess.rb:85: command not found: /sbin/ifconfig -a /usr/bin/facter:54: command not found: /sbin/ifconfig -a /usr/bin/facter:54: command not found: dnsdomainname /usr/bin/facter:54: command not found: domainname /usr/bin/facter:54: command not found: /sbin/ifconfig architecture => i386 domain => internal.HIDDEN facterversion => 1.3.8 fqdn => ruby-test.internal.HIDDEN hardwareisa => unknown hardwaremodel => i686 hostname => ruby-test id => root ipaddress => 10.200.201.73 </pre> It would be nice if when ifconfig can't be found, it falls back to using 'ip addr' - also, notice that domainname and dnsdomainname are not present on this system - however facter does appear to get them correct regardless. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
