Issue #8261 has been reported by Josh Cooper. ---------------------------------------- Bug #8261: Summary compliance counts are incorrect https://projects.puppetlabs.com/issues/8261
Author: Josh Cooper Status: Unreviewed Priority: Normal Assignee: Daniel Pittman Category: Target version: Keywords: Branch: Affected URL: Affected Dashboard version: Dashboard displays compliance counts (unreviewed, accepted, rejected) in several places, using different sets of queries, all of which are not correct. On the main compliance page, the following NodeBaseline methods are used: <pre> self.resource_counts_for_group_and_date self.resource_counts_for_node_ids_and_date self.node_count_for_group_and_date </pre> These methods recursively evaluate the nodes in the group using NodeGroup#.all_nodes. Randall has said this is not the desired behavior. In other words, the counts should only include direct children of the group, but not children of nested groups. There are additional NodeBaseline methods used to calculate compliance counts for a given date. These methods include: <pre> self.unreviewed_node_count_for_date ... self.unreviewed_diff_count_for_date ... </pre> These set of methods do not restrict the query to nodes that belong to the group being viewed. So when you've drilled into compliance for a group, the heading displays "Unreviewed: X nodes, Y differences", but X and Y include NodeBaselines/BaselineDifferences whose nodes are not a member of the group being viewed. It also does not restrict to the query to the "self_comparisons" named scope, which will be necessary once we support adhoc group reporting. In other words, when an adhoc group report is generated, it can result in multiple NodeBaselines for a node on a given date, but we want to exclude rows where node_id <> reference_node_id when generating compliance counts. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
