Issue #7789 has been updated by Matt Robinson.

Status changed from Needs Decision to Accepted

The spec tests should never depend upon where they're run, that's what 
acceptance level tests are for.  The Facter operatingsystem values should be 
stubbed out, and this really should be done in the specs for each individual 
default providers, so pretty all the tests in the 
spec/integration/type/package_spec.rb should be moved to the appropriate 
locations which would leave this file empty and unnecessary.
----------------------------------------
Refactor #7789: spec/integration/type/package_spec.rb specifies OS specific 
defaults that are not scalable
https://projects.puppetlabs.com/issues/7789

Author: James Turnbull
Status: Accepted
Priority: Normal
Assignee: Matt Robinson
Category: testing
Target version: 
Affected Puppet version: 
Keywords: 
Branch: 


The integration test: spec/integration/type/package_spec.rb specifies a list of 
platforms and default providers.

 def provider_name(os)
     {"Ubuntu" => :apt, "Debian" => :apt, "Darwin" => :pkgdmg, "RedHat" => 
:up2date, "Fedora" => :yum, "FreeBSD" => :ports, "OpenBSD" => :openbsd, 
"Solaris" => :sun}[
  end

Tests on platforms not listed fail.  This seems to me to the wrong approach.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to