Issue #8350 has been updated by Jeff McCune. Due date set to 07/15/2011 Branch set to ticket/8343_create_should_print_dnsname_asap/8350_log_destination
# Ready to merge # James gave the +1, I rebased and added the Reviewed-by lines to the commit logs. Pushed to: `ticket/8343_create_should_print_dnsname_asap/8350_log_destination` Added the progress bar as per Nigel's feedback: <pre> commit 046879a9868a397dc9975f9e06c9873d4b40e57d Author: Jeff McCune <[email protected]> Date: Mon Jul 11 13:14:56 2011 -0700 (#8350) Change progress to a bar to avoid logspam In an effort to avoid log spam but also provide the end user interactive feedback, this change updates the shift from print and puts to only use print when outputting a progress bar. Hopefully, # will be interpreted as a comment in YAML renderings, and the user may filter all lines starting with # before creating a JSON pipeline. Reviewed-by: James Turnbull lib/puppet/cloudpack.rb | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) commit a61133c718422f7f47216d16b7f67fb88ef5f4b7 Author: Jeff McCune <[email protected]> Date: Mon Jul 11 12:44:17 2011 -0700 (#8350) Change all output to use logdest This change replaces all instances of print and puts with Puppet.{info,warning,err}(). This change is motivated by two main reasons: First, the standard behavior of the Faces API is to take the return value of an action and render the object to STDOUT for use in pipelines with other actions. Second, the Puppet end user already has an expectation that informational messages in Puppet are configurable using the log destination feature. Note, this change makes all of the cloudpack output and feedback silent unless the end user passes the --verbose flag. In addition, I disabled the fingerprint spec test checking if the finger print is printed to standard output. The test was passing before this change and I've never seen the fingerprint printed to STDOUT so I don't think it was working anyway. In addition, #8348 proposes fingerprinting will be it's own action which should simply return a string to the API for rendering to the user. The spec test should be unmarked as pending in that ticket. Reviewed-by: James Turnbull lib/puppet/cloudpack.rb | 98 +++++++++++++++++++----------------- spec/unit/puppet/cloudpack_spec.rb | 1 + 2 files changed, 52 insertions(+), 47 deletions(-) </pre> ---------------------------------------- Refactor #8350: All output should go to a log destination https://projects.puppetlabs.com/issues/8350 Author: Jeff McCune Status: Accepted Priority: Normal Assignee: Jeff McCune Category: Target version: Keywords: cloudpack, faces Branch: ticket/8343_create_should_print_dnsname_asap/8350_log_destination # Overview # We're currently using print and puts in Cloud Pack and this breaks the ability to pipe rich data into other actions. In addition, informational messages do not adhere to the standard log destination configured by the end user. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
