Issue #8506 has been updated by Jeff McCune. Status changed from Accepted to Merged - Pending Release Target version set to 0.4 Branch set to ticket/master/8506_cannot_install_modules_with_dashes
# Merged # Dan reviewed, mailed puppet-dev, updated ticket. <pre> commit 5423a75625355b9ecacdfc60bc48e1a34052d116 Merge: c33c6a9 9bc9dc4 Author: Jeff McCune <[email protected]> Date: Tue Jul 19 16:41:06 2011 -0700 Merge branch 'ticket/master/8506_cannot_install_modules_with_dashes' * ticket/master/8506_cannot_install_modules_with_dashes: (#8506) Add ability to install modules with hyphens commit 9bc9dc499b039463843caa2ee7eb147bf575837c Author: Jeff McCune <[email protected]> Date: Tue Jul 19 16:32:55 2011 -0700 (#8506) Add ability to install modules with hyphens This change fixes the module filename parsing method to support module names with hyphens and dashes in them. Without this change the following module name was causing an error in the install action: puppetlabs-cloud-provisioner-0.0.1git-95-g6541187.tar.gz This error was caused by the module tool doing a simple split on the filename. This change uses a more robust regular expression to parse the username, module name, and semantic version from the package filename. Reviewed-by: Dan Bode </pre> ---------------------------------------- Bug #8506: PMT cannot install modules with hyphens in their name https://projects.puppetlabs.com/issues/8506 Author: Jeff McCune Status: Merged - Pending Release Priority: Normal Assignee: Jeff McCune Category: module tool Target version: 0.4 Keywords: name hyphen dash semantic version semver Branch: ticket/master/8506_cannot_install_modules_with_dashes Affected URL: # Overview # The addition of semantic version support appears to have broken puppet-module's ability to install a module with a hyphen in the name: <pre> + puppet-module build ====================================================== Building /Users/jeff/src/modules/cloudpack for release ------------------------------------------------------ Done. Built: pkg/puppetlabs-cloud-provisioner-0.0.1git-95-g6541187.tar.gz + git checkout -- Modulefile + pushd /Users/jeff/vms/moduledev/modules ~/vms/moduledev/modules ~/src/modules/cloudpack + puppet-module install /Users/jeff/src/modules/cloudpack/pkg/puppetlabs-cloud-provisioner-0.0.1git-95-g6541187.tar.gz --force Invalid version format: provisioner-0.0.1git-95-g6541187 (Semantic Versions are acceptable: http://semver.org) </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
