Issue #6026 has been updated by Jacob Helwig.
Status changed from Accepted to Merged - Pending Release
Target version changed from 2.7.x to 2.7.3
This has been merged into `2.7.x` in
commit:5682125e1800f4c7b69b20fdd28f97a473d5d93c and `master` in
commit:5b167eba2b602f5c6c6c224790fa1eb56b239ad4
This modifies the regex used to match and parse the rules:
commit 6401dfe5602fd39cc59ec1f1b3822110e4ad864a
Author: Brice Figureau <[email protected]>
Date: Mon May 30 11:31:14 2011
Fix #6026 - security file should support inline comments
Auth.conf, namespaceauth.conf and fileserver.conf were not supporting
trailing inlined comments.
Also this commit fixes some indentation and error management.
Signed-off-by: Brice Figureau <[email protected]>
----------------------------------------
Bug #6026: Config files don't allow for comments at the end of a line anymore
https://projects.puppetlabs.com/issues/6026
Author: f p
Status: Merged - Pending Release
Priority: High
Assignee:
Category:
Target version: 2.7.3
Affected Puppet version: 0.25.5
Keywords: fileserver.conf whitespace comments
Branch: https://github.com/masterzen/puppet/tree/tickets/2.7.x/5777
Hello, using the latest epel package
(http://download.fedora.redhat.com/pub/epel/5/x86_64/puppet-0.25.5-1.el5.noarch.rpm)
of puppet (centos 5.5) I initially added a comment like so in the
fileserver.conf
<pre>
[mydir]
/dir
allow 8.8.8.8 # my comment
</pre>
this causes puppetmasterd to crash without any particular handy warnings as to
why in any log files I could discover. I was able to find it with running
'puppetmasterd --no-daemonize --debug --logdest console --verbose' and watching
for an error.
No big deal on comments not allowed this way, so I removed the "# my comment"
leaving a single white space char " " so the entry was "allow 8.8.8.8 " (space
after the last 8) and that also causes puppetmasterd to crash without notice.
This white space removal seems like a bug to me, but this is by no means
critical. Even if the whitespace thing is on purpose the error message should
say something rather then have users hunt for this (imo).
I searched for any known issues like this but did not find any, so if this is a
dupe then I'm blind and sorry for wasting someone's time.
keep up the good work puppet developers!
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
