Issue #4762 has been updated by Nick Lewis.

Status changed from In Topic Branch Pending Merge to Merged - Pending Release

Merged to 2.7.x in commit:2185bb2804aeef6b419667951b2157b01404c694.
----------------------------------------
Bug #4762: Speed of light interfering with normal puppet operation
https://projects.puppetlabs.com/issues/4762

Author: John Ferlito
Status: Merged - Pending Release
Priority: High
Assignee: Nigel Kersten
Category: Doh!
Target version: 2.7.3
Affected Puppet version: 0.25.5
Keywords: speed of light in a vacuum 
Branch: 


Puppet::Network::HTTP::WEBrick doesn't wait long enough for the connection to 
establish

In puppet/network/http/webrick.rb

there is the following code

       @mutex.synchronize do
            raise "WEBrick server is already listening" if @listening
            @listening = true
            @thread = Thread.new {
                @server.start { |sock|
                    raise "Client disconnected before connection could be 
established" unless IO.select([sock],nil,nil,0.1)
                    sock.accept
                    @server.run(sock)
                }
            }
            sleep 0.1 until @server.status == :Running
        end
    end 

The select only waits for 100ms. In my situation I have servers in US and 
puppet masters in Australia. 100ms is nowhere near long enough for the 
connection to establish

Maybe 2-5 seconds would be more appropriate



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to