Issue #3321 has been updated by Nigel Kersten.

Status changed from Needs Decision to Accepted
Assignee deleted (Nigel Kersten)
Target version set to Telly


----------------------------------------
Feature #3321: puppetd should resplay after puppetrun is called
https://projects.puppetlabs.com/issues/3321

Author: Dan Bode
Status: Accepted
Priority: Normal
Assignee: 
Category: plumbing
Target version: Telly
Affected Puppet version: 0.25.4
Keywords: puppetrun splay
Branch: 


It appears that splay is set the first time that puppetd runs, then never 
again. This even applies to calls with puppetrun. Here is the problem with this:

 - if I call puppetrun, and all machines check in, they will all check in at 
the same time and never resplay. This means that all machines will continue to 
pound the server at the exact same time every runinterval(assuming that all 
machines have the same run interval).

The ideal solution would be as follows:

  - puppetrun is called, puppetd runs immediately
  - puppetrun sets @splay=false after it runs, so that the next puppetd call 
will resplay.

maybe this should be an option, although it seems like this should be the 
default behavior.

there is a related bug #1100

Here is the related code from agent.rb that sets splay to only occur once.
<pre>
    # Have we splayed already?
    def splayed?
        splayed
    end

    # Sleep when splay is enabled; else just return.
    def splay
        return unless Puppet[:splay]
        return if splayed?

        time = rand(Integer(Puppet[:splaylimit]) + 1)
        Puppet.info "Sleeping for %s seconds (splay is enabled)" % time
        sleep(time)
        @splayed = true
    end
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to