Issue #7270 has been updated by Daniel Pittman.

Kelsey  Hightower wrote:
> I am submitting a patch that takes a "small" step forward by exposing 
> non-standard configuration parameters set in `puppet.conf`, the cli, or any 
> thing that uses `Puppet::Util::Settings.set_value`. This allows Puppet Faces 
> to reference custom parameters set in `puppet.conf` . Please review my branch 
> and let me know if I am heading in the right direction.

Hey.  I took a look, and it feels like a reasonable enough approach.  I think 
if that is wired up so that it works correctly for configuration file options – 
ideally, nested, so you can create arbitrary sections, and options in those 
sections – then it would be acceptable.  Given how core this is, we will need 
to have tests against it.
----------------------------------------
Bug #7270: unify global options with face and action options...
https://projects.puppetlabs.com/issues/7270

Author: Daniel Pittman
Status: Accepted
Priority: Low
Assignee: 
Category: Faces
Target version: 2.7.x
Affected Puppet version: development
Keywords: 
Branch: https://github.com/khightower/puppet/commits/feature/master/7270


At the moment we handle global options for faces in a ... different way.  They 
are basically the old fashioned application options, kind of vaguely repurposed 
to do something approximating the right thing.  We should unify the behaviour 
of those, ideally along with options derived from our configuration system, and 
make them all behave consistently.

This would naturally want to involve unification of the DSL for declaring 
options, and in turn for introspection of them: that would make it practical to 
have them in the help output, and so forth.  Which is desirable, especially 
round the area of option validation.

It also means we can unify error handling, so that we don't have some classes 
of validation resulting in good help output, and others resulting in bad help 
output, just because they are handled by different substrates in the product.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to