Issue #8651 has been updated by Jacob Helwig.

Status changed from Accepted to Merged - Pending Release

This was fixed as part of commit:1e59b268063772a59efdc810e5967c63e05cdb2d

    Always put a slash between the checksum and path in filebucket URLs

    Since absolute paths on Windows do not always start with /, we need to
    make sure that there is always a slash between the checksum and the
    path, or the drive letter will end up being considered as part of the
    checksum.

    On systems where absolute paths always start with /, the extra slash
    is removed by the parsing done to the constructed URL.

----------------------------------------
Bug #8651: Indirector does not handle windows paths
https://projects.puppetlabs.com/issues/8651

Author: Josh Cooper
Status: Merged - Pending Release
Priority: Normal
Assignee: 
Category: windows
Target version: 2.7.x
Affected Puppet version: 
Keywords: 
Branch: 


Various indirections encode file paths in URI's such as file dipper, file 
bucket, file server, but do not work with Windows paths. 

For example, in lib/puppet/file_bucket/dipper.rb:

<pre>
Puppet::FileBucket::File.indirection.head("#{@rest_path}#{file_bucket_file.checksum_type}/#{file_bucket_file.checksum_data}#{files_original_path}")
</pre>

where files_original_path is of the form "C:/foo/bar". But later in 
lib/puppet/indirector/file_bucket_file/file.rb this is parsed as:

<pre>
checksum_type, checksum, path = request.key.split(/\//, 3)
</pre>

The split causes C: to be included in the checksum, which results in an 
exception "Invalid checksum" on line 107

Note that any changes made should not break backwards compatibility between 
newer puppetmasters and older agents.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to