Issue #9167 has been updated by Kelsey Hightower.
So my patch results in the follow output in the logs:
Aug 24 23:52:44 master puppet-agent[7485]: Caching catalog for
master.lab.org
Aug 24 23:52:44 master puppet-agent[7485]: Applying configuration version
'1314244364'
Aug 24 23:52:44 master puppet-agent[7485]: Finished catalog run in 0.03
seconds
Aug 24 23:52:44 master puppet-master[7446]: Handling request: PUT
/production/report/master.lab.org
Aug 24 23:52:44 master puppet-master[7446]: Recieved report to process from
master.lab.org
Aug 24 23:52:44 master puppet-master[7446]: Processing report from
master.lab.org with processor Puppet::Reports::Store
Aug 24 23:52:45 master puppet-master[7446]: Processing report from
master.lab.org with processor Puppet::Reports::Http
Aug 24 23:52:45 master puppet-master[7446]: Processing report from
master.lab.org with processor Puppet::Reports::Tagmail
Aug 24 23:52:45 master puppet-master[7446]: Not sending tagmail report; no
changes
Notice the last line: "Not sending tagmail report; no changes". This patch also
prevents the tagmail report (email) from being sent if the status of the puppet
run is "unchanged".
### Tests ###
I could not figure out a good way to test this patch so I have created a
pending example in `spec/unit/reports/tagmail_spec.rb`.
----------------------------------------
Bug #9167: tagmail report sends email when nothing happens
https://projects.puppetlabs.com/issues/9167
Author: Spencer Rinehart
Status: Accepted
Priority: Low
Assignee: Kelsey Hightower
Category: reports
Target version:
Affected Puppet version: 2.7.3
Keywords: tagmail
Branch: https://github.com/khightower/puppet/tree/bug/master/9167
Since upgrading to the 2.7 series (2.6.8 -> 2.7.3), the tagmail report will
send an email with 1 line, shown below, after every run. Before the upgrade,
it would only send emails when something occurred during the puppet run.
Steps to reproduce:
Enable tagmail report
Execute a puppet run that produces no updates
Expected result:
No email sent
Actual result:
Email sent with line below
Email body:
Tue Aug 23 13:11:59 -0400 2011 Puppet (notice): Finished catalog run in 16.60
seconds
tagmail.conf:
all: [email protected]
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
