Issue #9183 has been updated by Adrien Thebo. Status changed from Tests Insufficient to Requires CLA to be signed Branch set to https://github.com/adrienthebo/facter/tree/ticket/master/9183-add_alpine_linux_detection
The reason the tests were failing is that where Facter::Util::Resolution.exec was stubbed out elsewhere, the new 'cat' was also being called, which wasn't expected. I partially rewrote the operatingsystemrelease fact to use File.read instead of cat, which is a little bit simpler and easiest to test. At this point, could you sign the CLA so that we can get your code merged? Thanks! ---------------------------------------- Feature #9183: Add support for alpine linux https://projects.puppetlabs.com/issues/9183 Author: Adrien Thebo Status: Requires CLA to be signed Priority: Normal Assignee: Adrien Thebo Category: Target version: Keywords: Branch: https://github.com/adrienthebo/facter/tree/ticket/master/9183-add_alpine_linux_detection Affected Facter version: Code for detection is located at https://github.com/jda/facter/commit/05df4ea031a2922ff3bd0c0f40480d91d3e36bee , but needs tests. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
