Issue #9203 has been updated by Nigel Kersten. Status changed from Needs Decision to Accepted Assignee deleted (Nigel Kersten) Priority changed from Urgent to High
---------------------------------------- Bug #9203: Change namespace for semver.rb https://projects.puppetlabs.com/issues/9203 Author: darix . Status: Accepted Priority: High Assignee: Category: API Target version: 2.7.x Affected Puppet version: 2.7.3 Keywords: Branch: 1. your copy of the file differs from https://github.com/flazz/semver/blob/master/lib/semver.rb wouldnt it be better to move the changed copy into the puppet namespace to avoid problems when people require semver and expect to get the gem version? 2. I couldnt find a reference to the license of the file neither in the "upstream" git nor in your copy. 3. shouldnt the readme mention that you include code from https://github.com/flazz/semver 4. how about depending on the gem instead of copying the code? -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
