Issue #4624 has been updated by Daniel Pittman.
Normally, we only splay once. It isn't clear what the best semantics around this would be: 1. Always splay when we run (eg: as it is implemented now) 2. Force an immediate run when you get the signal, but splay on the next scheduled run. 3. Force an immediate run when you get the signal, and consider ourselves "splayed" already. I agree that splaying when you are asked to run is wrong; so does the documentation. I *think* that forcing an immediate run, but doing the splay normally next time around, is the right long term behaviour. ---------------------------------------- Bug #4624: SIGUSR1 should ignore splay https://projects.puppetlabs.com/issues/4624 Author: eric sorenson Status: Accepted Priority: Normal Assignee: Category: agent Target version: Affected Puppet version: 0.25.5 Keywords: splay signal usr1 Branch: When testing whether I could trigger an immediate run to a running puppetd, I found I could not. I can understand HUP (restart) simply causing a from-the-top restart of execution, but it surprised me that USR1 (reload) behaved the same. IMO if I'm actively sending a reload signal to the daemon, I'd like it to take action immediately, not restart the splay timer. <pre> notice: Starting Puppet client version 0.25.5 info: Sleeping for 902 seconds (splay is enabled) [1]+ Stopped puppetd --no-daemonize --debug [root@pt-linux17 /etc/rc.d/init.d]# killall -USR1 puppetd [root@pt-linux17 /etc/rc.d/init.d]# fg puppetd --no-daemonize --debug notice: Caught USR1; calling reload info: Sleeping for 179 seconds (splay is enabled) [1]+ Stopped puppetd --no-daemonize --debug [root@pt-linux17 /etc/rc.d/init.d]# killall -USR1 puppetd [root@pt-linux17 /etc/rc.d/init.d]# fg puppetd --no-daemonize --debug notice: Caught USR1; calling reload info: Sleeping for 1366 seconds (splay is enabled) </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
