Issue #9451 has been updated by R.I. Pienaar. Status changed from In Topic Branch Pending Merge to Code Insufficient
Michael Stahnke wrote: > * reference to SUSE probably should be removed. (I can understand why they > are there, but I don't think that's compatible with the guidelines from > Fedora.) This one is debatable to me. Regarding the SUSE stuff, the goal with the spec file is not to make only fedora happy. It's a specfile for the users to build a usable set of packages, various people use it to just rake rpm on their machines and so get coverage on distros and versions we don't directly support ourself. Hence vendoring some stuff, support for various distro's etc. If we wanted to host in the project a Fedora specific spec file it should go into ext somewhere. Please bear that in mind while working on this. I've updated the rpms/debs with the application plugin change mentioned above as well as removed the deprecated mc-* scripts so your changes will need to be rebased on whats in master now. ---------------------------------------- Feature #9451: RPM Spec file improvements https://projects.puppetlabs.com/issues/9451 Author: Michael Stahnke Status: Code Insufficient Priority: Normal Assignee: Michael Stahnke Category: Packaging Target version: Keywords: Branch: Affected mCollective version: I've made some changes to the rpm spec for mcollective. I'll try to explain most of them. I am trying to get mcollective as close as possible to following the Fedora/EPEL packaging guidelines. There are a couple issues that would prevent this from going into EPEL as is, mainly the vendoring of json and systemu. Assuming those could hit the system installed versions, then this would be compliant, I think. * Replaced hard-coded paths with macros where appropriate %{_bindir} rather than /usr/bin, etc * Used valid Group as found in /usr/share/doc/rpm-*/GROUPS on an EL or Fedora System * Do not enable the daemon/service by default (this is actually an init script change) * Remove zero-byte files * Remove .gitignore files * Don't mix tabs and spaces in spec file * Provide URL * Remove Packager tag * Update source url * Replace %define with %global * Update license to official RH abbreviations (http://fedoraproject.org/wiki/Licensing:Main) * Remove explicit package requirements for each package as they are implied if they require the base package (ruby, rubygems, etc) * reference to SUSE probably should be removed. (I can understand why they are there, but I don't think that's compatible with the guidelines from Fedora.) This one is debatable to me. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
