Issue #9639 has been updated by Eric Shamow. Assignee changed from Thomas Linkin to Jeff McCune
Jeff, A note here - I also thought that this was an RFC violation, but it's not. There's a later RFC amending this to allow digits to start a hostname: http://www.ietf.org/rfc/rfc1123.txt In particular: 2.1 Host Names and Numbers The syntax of a legal Internet host name was specified in RFC-952 [DNS:4]. One aspect of host name syntax is hereby changed: the restriction on the first character is relaxed to allow either a letter or a digit. Host software MUST support this more liberal syntax. ---------------------------------------- Bug #9639: bad mcollectivepe init.pp regex https://projects.puppetlabs.com/issues/9639 Author: Thomas Linkin Status: Needs More Information Priority: Normal Assignee: Jeff McCune Category: modules Target version: PE 2.0 (Cmdr Keith) Keywords: Branch: Affected URL: Affected PE version: In the file /opt/puppet/share/puppet/modules/mcollectivepe/manifests/init.pp, there is a regex on line 34 that does not account for all types of hostnames as per [[http://www.freesoft.org/CIE/RFC/1123/14.htm]]. Simple edit: 34: validate_re($fact_stomp_server, '^[a-zA-Z]\w*') new 34: validate_re($fact_stomp_server, '^[0-9]|[a-zA-Z]\w*') -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
