Issue #9708 has been updated by Adrien Thebo.
To be honest, I'm not sure if this is safe. However, what's been demonstrated is that the facts with these confines will work before there's an operatingsystem fact available for it, and when that's added and these confines are not updated, facts restricted by these confines start failing. Looking at Michael's changes, the hardwareisa fact should be fine, because if uname isn't on a linux then we clearly have other problems to worry about. Same goes for lsbmajdistrelease; if that's broken on a specific linux, that's more of the distro's problem than ours. With respect to the macaddress fact, we do see linux distributions moving away from net-tools and towards iproute2, but since we don't support the latter in any case, it won't break anything that isn't broken already. Again with hostid, if that's not included in a linux distro then it wouldn't resolve in any case. Daniel, what do you think? ---------------------------------------- Refactor #9708: Remove redundancy from operatingsystem confines https://projects.puppetlabs.com/issues/9708 Author: Adrien Thebo Status: In Topic Branch Pending Merge Priority: Normal Assignee: Adrien Thebo Category: library Target version: 1.6.x Keywords: Branch: Affected Facter version: There are instances inside facter that that look like this <pre> confine :operatingsystem => %w{Solaris Linux Fedora RedHat CentOS Scientific SuSE SLES Debian Ubuntu Gentoo FreeBSD OpenBSD NetBSD OEL OVS GNU/kFreeBSD} </pre> Which should be written more cleanly as <pre> confine :kernel => %w{SunOS Linux FreeBSD OpenBSD NetBSD GNU/kFreeBSD} </pre> </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
