Issue #9831 has been updated by Jacob Helwig. Status changed from Accepted to In Topic Branch Pending Review Target version set to 2.7.x Branch set to https://github.com/jhelwig/puppet/tree/tickets/2.7.x/9831-standardize-windows-provider-confines
Opened [pull request 164](https://github.com/puppetlabs/puppet/pull/164). (#9831) Standardize Windows provider confining The newly created providers for Windows were using a combination of ':operatingsystem => :windows' and ':feature => :microsoft_windows' for their confine and defaultfor calls. This brings them in line to all use the ':operatingsystem => :windows' form. The general reasoning being that :operatingsystem is used for things that are platform specific, where :feature is used for things that are supported across multiple platforms, but require that external (to Puppet or the base platform) support exist on the host. ---------------------------------------- Bug #9831: Unify windows provider confines https://projects.puppetlabs.com/issues/9831 Author: Josh Cooper Status: In Topic Branch Pending Review Priority: Normal Assignee: Jacob Helwig Category: windows Target version: 2.7.x Affected Puppet version: Keywords: Branch: https://github.com/jhelwig/puppet/tree/tickets/2.7.x/9831-standardize-windows-provider-confines We are confining windows providers differently (sometimes using operatingsystem, sometimes using feature, sometimes using both). We should pick one. <pre> % ack 'confine.*windows' lib/puppet/provider lib/puppet/provider/service/windows.rb 16: confine :operatingsystem => :windows lib/puppet/provider/exec/windows.rb 6: confine :feature => :microsoft_windows lib/puppet/provider/file/win32.rb 4: confine :feature => :microsoft_windows lib/puppet/provider/group/windows_adsi.rb 7: confine :operatingsystem => :windows 8: confine :feature => :microsoft_windows lib/puppet/provider/user/windows_adsi.rb 7: confine :operatingsystem => :windows 8: confine :feature => :microsoft_windows lib/puppet/provider/package/msi.rb 6: confine :operatingsystem => :windows </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
