Issue #7285 has been updated by Jacob Helwig. Status changed from Accepted to Tests Insufficient
Dominic, In going to review your branch for this I noticed that there weren't any tests. Before I dig in to add some (since I know next to nothing about Augeas), is there any chance I could convince you to add some for this change? ---------------------------------------- Feature #7285: Use Augeas NO_LOAD/incl to optimise loading https://projects.puppetlabs.com/issues/7285 Author: Dominic Cleal Status: Tests Insufficient Priority: Normal Assignee: Category: augeas Target version: Affected Puppet version: Keywords: augeas performance Branch: https://github.com/domcleal/puppet/tree/tickets/master/7285-augeas-198 Augeas will load all lenses and then read and parse all files listed in the default "incl" lists for all lenses when opened. A large speed increase could be gained by only loading the file(s) implied by the "context" property given in the augeas type. The NO_LOAD flag can be given to Augeas which will populate the /augeas/load//incl nodes, but it won't call aug_load to read the files. The incl nodes that aren't relevant can be deleted, then aug_load called to parse only the necessary files. This differs from the optimisation available when the lens and incl properties are given, as this wouldn't require the lens to be known or specified, nor would it require specifying both the context and incl properties (with near-identical values). -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
