Issue #10395 has been updated by Ken Barber.
<https://github.com/puppetlabs/facter/pull/91> ---------------------------------------- Bug #10395: changes to manufacturer_spec have caused test failure on windows https://projects.puppetlabs.com/issues/10395 Author: Ken Barber Status: In Topic Branch Pending Review Priority: Immediate Assignee: Ken Barber Category: testing Target version: 1.6.x Keywords: Branch: https://github.com/puppetlabs/facter/pull/90 Affected Facter version: 1.6.3rc1 This commit: <https://github.com/puppetlabs/facter/commit/b2a66a97eb518c5d6207353c18ce6056e9715995> Has caused the windows build to break: 1) Facter::Manufacturer should not set manufacturer or productname if prtdiag output is nil Failure/Error: Facter.value(:manufacturer).should be_nil expected: nil got: "Phoenix Technologies LTD" # ./spec/unit/util/manufacturer_spec.rb:36 Because we have forced the result to be nil, windows has fallen back to its in-built mechanism and returned the manufacturer which is not nil (therefore breaking the tests). -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
