Issue #2744 has been updated by Nick Lewis.
Daniel Pittman wrote: > > I'm concerned about the security implications of this. This diff could > > potentially contain sensitive information which shouldn't necessarily be > > published indiscriminately. > > Concretely, that matters because the diff ... ? Can you fill in the blank, > so I don't answer my own guess about what your concern is? Because we may be uploading secure information into a less-secure system (such as Dashboard, which may be shared amongst teams, and have a lighter security policy given its present lack of precisely this sort of information). > > At the very least, making this change in a point release worries me, as I > > would prefer a change with such a significant security impact be more > > conspicuous. > > That seems a reasonable concern, but we are somewhat committed by commercial > customers - who have demanded this feature for the 2.7 release. Nigel and > James are the people to make the final call about where this lands, and how > that plays with our promises. I won't complain much if this goes in; I just want to make sure that the decision is/was made with consideration of these potential issues. ---------------------------------------- Feature #2744: Provide an option to send back diff of txt files in reports https://projects.puppetlabs.com/issues/2744 Author: Yimin Li Status: In Topic Branch Pending Review Priority: Normal Assignee: James Turnbull Category: reports Target version: 2.7.x Affected Puppet version: 0.24.8 Keywords: Branch: When a txt file get replaced, only md5 of the new file is sent back to server. If there is an option that can be enabled to send back diff between new file and old file, then you can know what get changes in the reports/mails. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
