Issue #9983 has been updated by Jacob Helwig. Status changed from In Topic Branch Pending Review to Merged - Pending Release Target version changed from 2.7.x to 2.7.7
Merged into 2.7.x in commit:e8b9f64644eb3bbd6753e06c52258d07b63328b2 and into 2.7rc in commit:50c9394caaa1827b6e4432de9986f9004e0dc895 This moves most file operations to operate in binary mode to preserve line-endings, and avoid corrupting files as they are read/written across platforms. ---------------------------------------- Bug #9983: Files should be opened in binary mode https://projects.puppetlabs.com/issues/9983 Author: Josh Cooper Status: Merged - Pending Release Priority: Normal Assignee: Josh Cooper Category: windows Target version: 2.7.7 Affected Puppet version: 2.7.6 Keywords: Branch: https://github.com/puppetlabs/puppet/pull/192/commits Windows has a concept of text and binary file modes, where text mode automatically converts \r\n. This is not an issue when files are opened, read, etc within the context of a single Windows machine. But it is an issue if say a binary file is restored from a Unix file bucket, as the Windows agent will substitute each occurrence of '\n' to '\r\n', and in doing so corrupt the file. We should always open files in binary mode, which is a no-op on Unix. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
